D26393: Expand dynamic cast hierarchy.

[Adriaan de Groot]

adridg created this revision.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
adridg requested review of this revision.

REVISION SUMMARY
  On FreeBSD, with Clang 8 at least, the one-step dynamic cast
  from QAbstractItemModel* down to KeyListModelInterface*
  returns nullptr. Doing it in two steps (possibly because the
  interface is the second base class?) fixes the casts and returns
  the correctly-cast pointer.

TEST PLAN
  This is related to
  	https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242670
  	https://bugs.kde.org/show_bug.cgi?id=415168
  
  This manifests itself in Kleopatra by, for instance, the *Details*
  RMB item to be disabled, and double-clicking on a key doing nothing
  (because, internally, the model was returning nullptr, and then
  there's zero keys when it gets into DetailsCommand::doStart().

REPOSITORY
  R168 Kleopatra

BRANCH
  fix-freebsd

REVISION DETAIL
  https://phabricator.kde.org/D26393

AFFECTED FILES
  src/commands/command_p.h

To: adridg
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200103/7e523bf6/attachment.html>