D29265: Implement buffering in the DataStream class, to improve performance on Windows.

Daniel Vrátil noreply at phabricator.kde.org
Thu Apr 30 09:52:39 BST 2020


dvratil added inline comments.

INLINE COMMENTS

> datastream_p.cpp:45
>  {
> +    // No flush() here. Throwing an exception in a destructor would go badly. The caller MUST call flush after writing.
> +}

Why don't you just handle the exception in the destructor?

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D29265

To: dfaure, dvratil, kfunk
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200430/b7f81ca2/attachment.html>


More information about the kde-pim mailing list