D29291: [KJots] Provide explicit "Save" action

Igor Poboiko noreply at phabricator.kde.org
Wed Apr 29 21:32:01 BST 2020


poboiko added a comment.


  @dvratil: actually, there is an issue with saving on exit. Inside `KJotsEdit::savePage` we actually ask `ETM` to do the saving, which starts an async job.
  However, if we do it when quitting, we tend to quit *before* the job dispatches, and lose unsaved changes :(
  
  Is there a way to overcome this using `ETM`? Or should I just start `ItemModifyJob` by hand using non-async interface `job->exec()` here? 
  (actually, some feedback would probably be nice even when user presses `Ctrl+S`. E.g. change the cursor to "busy" one, or notify if there was an error and suggest to save it as a local file somewhere, etc...)

REPOSITORY
  R573 KJots

REVISION DETAIL
  https://phabricator.kde.org/D29291

To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200429/8ec00f25/attachment-0001.html>


More information about the kde-pim mailing list