D29148: [KJotsWidget] Fix several KJotsEdit focus issues (race condition)

Igor Poboiko noreply at phabricator.kde.org
Mon Apr 27 11:22:46 BST 2020


poboiko updated this revision to Diff 81323.
poboiko added a comment.


  In theory, `m_index` can't be nullptr, because `onLinkify` can be triggered only from `manage_link` action, 
  which becomes available only when `KJotsEdit` gains focus; `tooltipEvent` can also only trigger when `KJotsEdit`
  is available. And the only way `KJotsEdit` becomes available is through the `setModelIndex` call.
  
  In practice, let's be safe and guard it anyways :)

REPOSITORY
  R573 KJots

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29148?vs=81216&id=81323

BRANCH
  focus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29148

AFFECTED FILES
  src/kjotsbrowser.cpp
  src/kjotsbrowser.h
  src/kjotsedit.cpp
  src/kjotsedit.h
  src/kjotswidget.cpp
  src/kjotswidget.h

To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200427/37e45769/attachment.html>


More information about the kde-pim mailing list