D29162: [KJots] Drop custom internal links, use akonadi default ones
Igor Poboiko
noreply at phabricator.kde.org
Fri Apr 24 19:32:10 BST 2020
poboiko created this revision.
poboiko added a reviewer: dvratil.
Herald added a project: KDE PIM.
poboiko requested review of this revision.
REVISION SUMMARY
No need to maintain custom URL schemas, as akonadi already has its own, together with various
helper functions to work with it.
Remove `UrlRole` and use `EntityUrlRole` instead (use `akonadi:?item=...` links).
Remove custom `internal_link` clipboard property, just use the default mechanism for URL setting.
Teach `KJotsEdit` to insert `akonadi` links too. This also improves drag-n-drop from treeview,
which is now pasted properly (i.e. title of page/book instead of link itself)
TEST PLAN
1. Bookmarks work, both pages and books
2. `KJotsLinkDialog` works nicely
3. Tooltips also works
4. Ctrl+Click navigation works
REPOSITORY
R573 KJots
BRANCH
dragndrop (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29162
AFFECTED FILES
src/kjotsbookmarks.cpp
src/kjotsedit.cpp
src/kjotslinkdialog.cpp
src/kjotsmodel.cpp
src/kjotsmodel.h
src/kjotstreeview.cpp
src/kjotswidget.cpp
To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200424/9c6556e3/attachment.html>
More information about the kde-pim
mailing list