D28775: [KJots] Fix bookmarks actions

Thu Apr 23 11:46:23 BST 2020

poboiko added a comment.

  In D28775#655533 <https://phabricator.kde.org/D28775#655533>, @asturmlechner wrote:

  > Without ifdefs this is effectively raising minimum KF5 dependency to >=5.69:
  >
  > src/kjotswidget.cpp:360:40: error: no matching function for call to ‘KBookmarkMenu::KBookmarkMenu(KBookmarkManager*, KJotsBookmarks*&, QMenu*)’

  Right, sorry, haven't thought of it.

  @dvratil Is it OK do increase the dependency version, or should I add ifdefs?

REPOSITORY
  R573 KJots

REVISION DETAIL
  https://phabricator.kde.org/D28775

To: poboiko, dvratil
Cc: asturmlechner, winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200423/8058fb06/attachment.html>