D29087: [KJotsTreeView] Fix "copy link address" action

Igor Poboiko noreply at phabricator.kde.org
Wed Apr 22 12:47:29 BST 2020


poboiko created this revision.
poboiko added a reviewer: dvratil.
Herald added a project: KDE PIM.
poboiko requested review of this revision.

REVISION SUMMARY
  Previously, it copied an internal Akonadi url (i.e. `akonadi://?item=...`),
  which isn't recognized with KJots. Use newly introduced `KJotsModel::UrlRole` instead.
  
  The pasting code (`KJotsEdit`) did not cope well with unicode 
  (it was converted to `QLatin1String` before pasting), fixed that as well.
  
  Also, used `QStringLiteral` instead of `QLatin1String` for methods that don't have `QLatin1String` overload.

TEST PLAN
  1. Open KJots, right click on a book with non-latin1 title -> `Copy Link Address`
  2. It can be pasted inside KJots without problems

REPOSITORY
  R573 KJots

BRANCH
  fix-copy-link (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29087

AFFECTED FILES
  src/kjotsedit.cpp
  src/kjotstreeview.cpp

To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200422/73672ca7/attachment.html>


More information about the kde-pim mailing list