D29044: [KJots] Port deprecated code

[Pino Toscano]

pino added a comment.


  Hey @poboiko,
  
  a couple of notes for a followup patch -- no need to change this patch, as the code lacked the i18n handling also before (so this patch is not a regression).

INLINE COMMENTS

> KJotsMain.cpp:74
>      if (!anchorTarget.isEmpty()) {
> -        //QT5 statusBar()->changeItem(anchorText + QLatin1String(" -> ") + anchorTarget, 0);
> +        statusBar()->showMessage(QStringLiteral("%1 -> %2").arg(anchorText, anchorTarget));
>      } else {

As this is shown as visible string to the user, can you please use `i18n()` for this UI text? Ideally with a context (see `i18nc()`) explaining what %1 and %2 are, so translators can understand what the string will show.

> kjotspart.cpp:102
>      if (!anchorTarget.isEmpty()) {
> -        mStatusBar->statusBar()->showMessage(anchorText + QLatin1String(" -> ") + anchorTarget);
> +        mStatusBar->statusBar()->showMessage(QStringLiteral("%1 -> %2").arg(anchorText, anchorTarget));
>      } else {

Ditto.

REPOSITORY
  R573 KJots

BRANCH
  deprecated-methods (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29044

To: poboiko, dvratil
Cc: pino, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200421/b5f8ba30/attachment.html>