D29045: [KJots] Revive printing support
Daniel Vrátil
noreply at phabricator.kde.org
Tue Apr 21 12:28:56 BST 2020
dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kjotswidget.cpp:1119
>
> +QSharedPointer<QPrinter> KJotsWidget::setupPrinter()
> +{
If your intention is for the caller to own the QPrinter object, `std::unique_ptr` is a better choice.
REVISION DETAIL
https://phabricator.kde.org/D29045
To: poboiko, dvratil
Cc: kde-pim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200421/aa797ff6/attachment.html>
More information about the kde-pim
mailing list