D28761: T6446 Fix order of the GnuPG options

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> cryptoconfigmodule.cpp:231
>  
> +QStringList Kleo::CryptoConfigModule::sortComponentList(const QStringList &components) {
> +    // components sorting algorithm:

new line after ')'

> cryptoconfigmodule.cpp:235
> +    // 2. other components sorted alphabetically
> +    const QStringList order = {"gpg", "gpgsm", "gpg-agent", "dirmngr", "pinentry", "scdaemon"};
> +

QStringLiteral(...) around each element

> cryptoconfigmodule.cpp:248
> +    // add components with predefined order
> +    for (const auto &item: order) {
> +        if (input_set.contains(item)) {

(const auto &item : order)

REPOSITORY
  R90 PIM: Kleo Library

REVISION DETAIL
  https://phabricator.kde.org/D28761

To: andreylegayev, mlaurent
Cc: kde-pim, andreylegayev, fbampaloukas, dcaliste, dvasin, rodsevich, ach, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200419/54349815/attachment-0001.html>