D28994: Fix sorting & tabs preset in config file
Andrey Legayev
noreply at phabricator.kde.org
Sun Apr 19 19:15:02 BST 2020
andreylegayev created this revision.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
andreylegayev requested review of this revision.
REVISION SUMMARY
Fixes applied:
1. TabWidget and KeyTreeView were saving sorting preset to the same config group. I've fixed it by setting config group to View #1, 2, 3... as it should be. I've also had to prevent saving empty filter of last tab.
2. TabWidget didn't save settings on exit - added call to saveViews() to destructor
3. Prevented saving empty filter for the last tab in TabWidget::setKeyFilter()
TEST PLAN
Steps:
1. Create several tabs with different filters
2. Apply sorting to some columns
3. Exit from kleopatra
4. Run kleopatra
Expected result:
List of tabs, filters and sorting should be restored after app restart
REPOSITORY
R168 Kleopatra
REVISION DETAIL
https://phabricator.kde.org/D28994
AFFECTED FILES
src/view/tabwidget.cpp
To: andreylegayev
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200419/d86835a7/attachment.html>
More information about the kde-pim
mailing list