D28993: [KJots] Make compiler happier (use overrides, nullptr, explicit, QT_NO_KEYWORDS)
Igor Poboiko
noreply at phabricator.kde.org
Sun Apr 19 19:12:14 BST 2020
poboiko created this revision.
poboiko added a reviewer: dvratil.
Herald added a project: KDE PIM.
poboiko requested review of this revision.
REVISION SUMMARY
This patch does not contain any functional change, it only does following:
1. Add override keyword where applicable (also, remove empty dtors);
2. Make ctors explicit;
3. Use `nullptr` instead of 0;
4. Add `QT_NO_KEYWORDS`, make code compile
TEST PLAN
it compiles
REPOSITORY
R573 KJots
BRANCH
overrides (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28993
AFFECTED FILES
CMakeLists.txt
src/KJotsMain.h
src/akonadi_next/notecreatorandselector.h
src/kjotsbookmarks.cpp
src/kjotsbookmarks.h
src/kjotsbookshelfentryvalidator.cpp
src/kjotsbookshelfentryvalidator.h
src/kjotsbrowser.cpp
src/kjotsbrowser.h
src/kjotsconfigdlg.cpp
src/kjotsconfigdlg.h
src/kjotsedit.cpp
src/kjotsedit.h
src/kjotslinkdialog.h
src/kjotslockjob.cpp
src/kjotslockjob.h
src/kjotsmodel.h
src/kjotspart.h
src/kjotsreplacenextdialog.h
src/kjotssortproxymodel.cpp
src/kjotssortproxymodel.h
src/kjotstreeview.cpp
src/kjotstreeview.h
src/kjotswidget.cpp
src/kjotswidget.h
src/knowitimporter.cpp
src/kontact_plugin/kjots_plugin.cpp
src/kontact_plugin/kjots_plugin.h
src/localresourcecreator.cpp
src/localresourcecreator.h
src/noteshared/localresourcecreator.cpp
src/noteshared/localresourcecreator.h
src/noteshared/notelockattribute.cpp
src/noteshared/notelockattribute.h
To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200419/873d3289/attachment-0001.html>
More information about the kde-pim
mailing list