D28759: Akonadi-contacts: define BUILD_TESTING in order that CONTACTEDITOR_TESTS_EXPORT is properly defined
Kevin Funk
noreply at phabricator.kde.org
Fri Apr 17 11:25:43 BST 2020
kfunk updated this revision to Diff 80362.
kfunk added a comment.
Update.
Commit message:
Revert "Fix windows build"
That patch was wrong. BUILD_TESTING needs to always be defined when
testing is enabled so the *_TESTS_EXPORT macros are filled out properly.
I think this patch initially just worked around an issue which was fixed
by https://phabricator.kde.org/D20091.
Phabricator Revisino: https://phabricator.kde.org/D28759
This reverts commit 2f552ac573770ce22ec5489b22c6269280aa4e36.
REPOSITORY
R459 Akonadi Contacts
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28759?vs=80361&id=80362
BRANCH
release/19.12
REVISION DETAIL
https://phabricator.kde.org/D28759
AFFECTED FILES
CMakeLists.txt
src/akonadi-contacts/CMakeLists.txt
src/contact-editor/CMakeLists.txt
To: winterz, vonreth, dvratil, mlaurent, dfaure
Cc: kfunk, vonreth, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200417/8a7a26da/attachment.html>
More information about the kde-pim
mailing list