D28450: [messagecomposer]: Implement protected headers for SignEncryptJob.

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> signencrypttest.cpp:2
>  /*
> -  Copyright (C) 2009 Klaralvdalens Datakonsult AB, a KDAB Group company, info at kdab.net
> -  Copyright (c) 2009 Leo Franchi <lfranchi at kde.org>

same

> signencrypttest.cpp:96
> +    if (!error.isEmpty()) {
> +        QVERIFY(seJob->exec() == false);
> +        QCOMPARE(seJob->errorString(), error);

QVERIFY(! ... )

> signencrypttest.cpp:130
> +
> +    QStringList recipients;
> +    recipients << QString::fromLocal8Bit("test at kolab.org");

const QStringList recipient = {...};

> signencrypttest.cpp:191
> +    f.write(encodedContent);
> +    if (!encodedContent.endsWith("\n")) {
> +        f.write("\n");

endsWith('\n') ?

> signencrypttest.h:2
>  /*
> -  Copyright (C) 2009 Klaralvdalens Datakonsult AB, a KDAB Group company, info at kdab.net
> -  Copyright (c) 2009 Leo Franchi <lfranchi at kde.org>

why removed old copyright ?

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D28450

To: knauss, #kde_pim, mlaurent
Cc: mlaurent, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200414/e0ca5874/attachment.html>