D28775: [KJots] Fix bookmarks actions

Igor Poboiko noreply at phabricator.kde.org
Sun Apr 12 15:56:36 BST 2020


poboiko created this revision.
poboiko added a reviewer: dvratil.
Herald added a project: KDE PIM.
poboiko requested review of this revision.

REVISION SUMMARY
  This patch ports KJots from deprecated `KBookmarksMenu` API (see D25660: Decouple KBookmarksMenu from KActionCollection <https://phabricator.kde.org/D25660>).
  
  On my machine, it also fixes a crash (`bm_action` was null for some reason,
  I did not investigate it though).
  
  It also fixes the shortcuts collision (`action->setShortcut` was not enough,
  one also needs to run `actionCollection->setDefaultShortcut`).
  
  BUG: 384000

TEST PLAN
  1. Start KJots
  2. It don't crash, and `Ambiguous shortcuts` dialog does not appear)
  3. Open `Bookmarks` menu, the shortcut is `Ctrl+Shift+B`.

REPOSITORY
  R573 KJots

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28775

AFFECTED FILES
  src/kjotswidget.cpp

To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200412/6468587f/attachment-0001.html>


More information about the kde-pim mailing list