D28759: Akonadi-contacts: define BUILD_TESTING in order that CONTACTEDITOR_TESTS_EXPORT is properly defined

Allen Winter noreply at phabricator.kde.org
Sat Apr 11 17:21:27 BST 2020


winterz created this revision.
winterz added reviewers: vonreth, dvratil, mlaurent.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
winterz requested review of this revision.

REVISION SUMMARY
  An attempt to fix linking on Windows.
  
  you'll notice that src/contact-editor/contacteditor_private_export.h does not properly define CONTACTEDITOR_TESTS_EXPORT unless BUILD_TESTING is defined
  
  @vonreth if this works, would you be able to update craft to use it? perhaps with a patch?

TEST PLAN
  seems to link ok on Windows now

REPOSITORY
  R459 Akonadi Contacts

REVISION DETAIL
  https://phabricator.kde.org/D28759

AFFECTED FILES
  src/contact-editor/CMakeLists.txt

To: winterz, vonreth, dvratil, mlaurent
Cc: vonreth, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200411/f4f31462/attachment.html>


More information about the kde-pim mailing list