D28732: POP3: Remove the singleton pattern from Settings

[Daniel Vrátil]

dvratil created this revision.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
dvratil requested review of this revision.

REVISION SUMMARY
  It's causing issues with the "new" out-of-process settings
  dialog which initializes a new Settings object each time and asserts
  when the SettingsHelper Q_GLOBAL_STATIC is already initialized.
  
  Instead just get rid of the singleton pattern and have Settings
  object be owned by whomever created it and pass a reference to it
  to the classes that need it.
  
  BUG: 419726

REPOSITORY
  R44 KDE PIM Runtime

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28732

AFFECTED FILES
  resources/pop3/accountwidget.cpp
  resources/pop3/accountwidget.h
  resources/pop3/jobs.cpp
  resources/pop3/jobs.h
  resources/pop3/pop3config.cpp
  resources/pop3/pop3resource.cpp
  resources/pop3/pop3resource.h
  resources/pop3/settings.cpp
  resources/pop3/settings.h

To: dvratil
Cc: mkoller, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200410/19337859/attachment.html>