D28448: Implement of "Protected Headers for Cryptographic E-mail". T742

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> encryptjobtest.cpp:274
> +    f.write(encodedContent);
> +    if (!encodedContent.endsWith("\n")) {
> +        f.write("\n");

endsWith('\n')

> setupenv.cpp:100
> +    // compare to reference file
> +    auto args = QStringList()
> +           << QStringLiteral("-u")

const auto

> protectedheaders.cpp:133
> +    auto subject = d->skeletonMessage->header<KMime::Headers::Subject>();
> +    for(const auto header: d->skeletonMessage->headers()) {
> +        const QByteArray headerType(header->type());

const auto headers = d->skeletonMessage->headers();
for (const auto &header : headers) {
}

fix missing space after "for" and  '('  too

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D28448

To: knauss, #kde_pim, mlaurent
Cc: mlaurent, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200409/1adf99d0/attachment.html>