D28609: Add macro EXPORT_KONTACT_PLUGIN_WITH_JSON

[Friedrich W. H. Kossebau]

kossebau added a comment.


  "Looks" okay to me from pure code reading for what ecm_setup_qtplugin_macro_names matters. Cannot test though, no PIM devel setup sadly.

INLINE COMMENTS

> CMakeLists.txt:38
>  
> +include(ECMSetupQtPluginMacroNames)
> +ecm_setup_qtplugin_macro_names(

I would group the `include(ECMSetupQtPluginMacroNames)` with the other includes for consistency.

> plugin.h:67
>  /**
> -  Increase this version number whenever you make a change in the API.
> +  Exports Kontact plugin.
>   */

Perfect would be to document the paramters also :)

> plugin.h:69
>   */
> -#define KONTACT_PLUGIN_VERSION 10
> +#define EXPORT_KONTACT_PLUGIN_WITH_JSON( pluginclass, pluginname, jsonFile ) \
> +    class Instance                                           \

What is the purpose of pluginname?

REPOSITORY
  R85 PIM: Kontact Interface

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28609

To: dfaure, winterz, mlaurent
Cc: kossebau, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200408/6dab2294/attachment.html>