D28609: Add macro EXPORT_KONTACT_PLUGIN_WITH_JSON

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D28609#643225 <https://phabricator.kde.org/D28609#643225>, @dfaure wrote:
  
  > Use ECMSetupQtPluginMacroNames.
  >
  > Not sure I see the point in writing 6+1 lines in order to generate 3
  >  (or 3+1 vs 3 with less wrapping), but OK :)
  
  
  Yes, it makes more sense in projects which use the macro also in the same project.  Here I proposed it more for the sake of consistency, and promoting its existance, so others just copying code would learn about it.

INLINE COMMENTS

> CMakeLists.txt:43
> +    JSON_ARG3
> +       EXPORT_MYPLUGIN_WITH_JSON
> +   CONFIG_CODE_VARIABLE

You wanted "EXPORT_KONTACT_PLUGIN_WITH_JSON" here :)

REPOSITORY
  R85 PIM: Kontact Interface

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28609

To: dfaure, winterz, mlaurent
Cc: kossebau, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200406/57ee2db7/attachment-0001.html>