D28615: Discard duplicate results during contact completion

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Works great. Given the number of matches is limited by m_limit, this actually returns more useful contacts than before, to the user it's not just about deduplication (libkdepim does deduplicate on top anyway).
  
  One improvement would be to prefer matches with full name over matches without name.
  
  I type "vkrau" and it says:
  12:19:15.163 kmail2(16923/16923) org.kde.pim.akonadi_search_pim: processEnquire Match: "vkrause at kde.org" (50%), docid 7318456
  12:19:15.163 kmail2(16923/16923) org.kde.pim.akonadi_search_pim: processEnquire Skipped duplicate match "vkrause at kde.org" (50%) docid 13800517
  12:19:15.163 kmail2(16923/16923) org.kde.pim.akonadi_search_pim: processEnquire Match: "Volker Krause <vkrause at kde.org>" (47%), docid 1292769881
  12:19:15.163 kmail2(16923/16923) org.kde.pim.akonadi_search_pim: processEnquire Skipped duplicate match "Volker Krause <vkrause at kde.org>" (47%) docid 3129445885
  and I end up with just vkrause at kde.org in the completion, no name. Ah but this code returns both matches, it's libkdepim which deduplicates on top, and wrongly.
  
  So indeed the question is whether this code should do full deduplication (like your TODO says), or if that part is for libkdepim (which should then be improved).
  
  This also makes me wonder if the limit here is too low. I never realized I wasn't getting all matches but just a subset.
  
  Thanks!

REPOSITORY
  R42 Akonadi Search

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28615

To: dvratil, #kde_pim, dfaure
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200406/1f70d842/attachment-0001.html>