D28596: when decryption fails, copy mail encrypted

Martin Koller noreply at phabricator.kde.org
Sun Apr 5 16:29:50 BST 2020


mkoller created this revision.
mkoller added a reviewer: mlaurent.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
mkoller requested review of this revision.

REVISION SUMMARY
  In KMCopyDecryptedCommand, when decrypting a mail fails, it will try to create a new Akonadi::Item with no payload, which fails.
  
  This patch simply checks for the return value of MailCommon::CryptoUtils::decryptMessage() and if no mail is returned, it will use the original mail (same behavior as if an unknown encryption is found in CryptoUtils)

TEST PLAN
  "copy decrypted mail to..." with a mail which can not be decrypted
  (I have such mails but I still need to investigate why they can not be decrypted)

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D28596

AFFECTED FILES
  src/kmcommands.cpp

To: mkoller, mlaurent
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200405/fe1d87a6/attachment-0001.html>


More information about the kde-pim mailing list