D24301: Fix null pointer dereference, keep FileModifyJob metadata and serialize with options.

[David Barchiesi]

barchiesi created this revision.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
barchiesi requested review of this revision.

REVISION SUMMARY
  This patch fixes a couple issues regarding FileAbstractUploadJob and FileModifyJob:
  
  - Fix null pointer dereference that was causing BUG 411634 <https://bugs.kde.org/show_bug.cgi?id=411634>. This was introduced in D22787: Use mimeType from metadata instead of blindly re-determining it during uploads <https://phabricator.kde.org/D22787> and in the affected block of code the mime-type must be determined by LibKGAPI as no File metadata was provided.
  - Pass File metadata from FileModifyJob ctor to FileAbstractUploadJob ctor. This was letting KIO GDrive trigger the above bug when trying to specify the modified files mime-type.
  - Use provided serialization options also in FilePtr serialization during building multipart request.
  
  BUG: 411634

REPOSITORY
  R477 KGAPI Library

BRANCH
  bug_411634

REVISION DETAIL
  https://phabricator.kde.org/D24301

AFFECTED FILES
  src/drive/fileabstractuploadjob.cpp
  src/drive/filemodifyjob.cpp

To: barchiesi
Cc: kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190929/0e62db0f/attachment-0001.html>