D24230: Make *DefaultMessageColor use semantically correct colorscheme colors

Noah Davis noreply at phabricator.kde.org
Wed Sep 25 17:30:44 BST 2019


ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
ndavis requested review of this revision.

REVISION SUMMARY
  The unread message color was changed to ActiveText and the important message color was changed to NeutralText.
  
  After looking at the documentation in the KColorScheme header file, it seemed to me that ActiveText and NeutralText were more appropriate than Complementary FocusColor and NegativeText. ActiveText is appropriate for new items and Neutral Text is appropriate for warnings. Obviously, I can't use ActiveText for both and NegativeText is for errors, which important messages are not, so I used NeutralText for important messages.
  
  This currently results in almost no visual changes except for unread messages being a slightly brighter shade of blue and important messages being orange. In the future, I will change ActiveText in the Breeze colorscheme to yellow.

REPOSITORY
  R94 PIM: Message Library

BRANCH
  defaultmessagecolor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24230

AFFECTED FILES
  messagelist/src/messagelistutil.cpp

To: ndavis, #vdg
Cc: kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190925/f5472467/attachment-0001.html>


More information about the kde-pim mailing list