D24035: Fix reported bug about replies to self

[Glen Ditchfield]

gjditchfield marked 12 inline comments as done.
gjditchfield added inline comments.

INLINE COMMENTS

> knauss wrote in replystrategytest.cpp:113
> this only works on linux and please do not delete the complete `.qttest` dir, only the files that are problematic :
> 
>   QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation)+QDir::separator()  + QStringLiteral("emailidentities");

OK.  Is emaildefaults also problematic?

> knauss wrote in replystrategytest.cpp:175
> wait you have a original mail from `default -> friend2` and reply smart created a mail `default -> friend1`? Shouldn't it be :
> 
>   << (int)ReplySmart << defaultAddress << only(friend2Address) << nobody;

This a "normal mail" case:  from friend1, to the user's default identity, and Cc'd to friend2.  So the reply goes from the default identity to friend1, with no Cc.

(The test case for the bug in question is down at line 196.)

> knauss wrote in replystrategytest.cpp:179
> friend1Address vs. friend2Address

Here the original is from friend1, to the non-default identity (and also to friend2), so the reply goes from non-default to friend1 (and friend2 is not added to Cc.)

> knauss wrote in replystrategytest.cpp:251
> friend1 vs friend2

As above.

> knauss wrote in replystrategytest.cpp:255
> friend1 vs friend2

As above.

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D24035

To: gjditchfield, #kde_pim, mlaurent, knauss
Cc: mlaurent, knauss, kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190925/f1bc4d36/attachment.html>