D23979: Add missing parameters to Permission related jobs and fix url typo.

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Just minor nitpicks. Fix those and you can commit the patch. Thanks!

INLINE COMMENTS

> permission.cpp:36
> +
> +    PermissionDetails::PermissionType permissionType;
> +    Role role;

Should be initialized to `PermissionType::UndefinedType`

> permission.cpp:218
> +        const QVariantList permissionDetailsList = map[QStringLiteral("permissionDetails")].toList();
> +        for (const QVariant variant : permissionDetailsList) {
> +            const QVariantMap permissionDetailsMap = variant.toMap();

`const QVariant &` (or `const auto &`)

> permission.cpp:245
>  
>  Permission::Private::Private(const Private &other):
>      id(other.id),

Just replace the initialization section with `= default`, please, since you are touching this :)

REPOSITORY
  R477 KGAPI Library

REVISION DETAIL
  https://phabricator.kde.org/D23979

To: barchiesi, dvratil
Cc: #libkgapi, kde-pim, barchiesi, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190919/672e6f80/attachment-0001.html>