D24035: Fix reported bug about replies to self

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> replystrategytest.cpp:46
> +
> +static inline QStringList only(QString address)
> +{

const QString &address

> replystrategytest.cpp:51
> +
> +static inline QStringList both(QString address1, QString address2)
> +{

const QString &...

> replystrategytest.cpp:60
> +
> +static KMime::Message::Ptr basicMessage(QString fromAddress, QStringList toAddresses)
> +{

const QString & , const QStringList &

> replystrategytest.cpp:81
> +template<class T>
> +bool compareAddresses(const T* actual, const QStringList expected)
> +{

const QStringList &

> replystrategytest.cpp:96
> +
> +ReplyStrategyTest::ReplyStrategyTest(QObject* parent)
> +    : QObject(parent)

coding style QObjet *parent

> replystrategytest.cpp:139
> +
> +KMime::Message::Ptr ReplyStrategyTest::makeReply(const KMime::Message::Ptr original, const ReplyStrategy strategy)
> +{

const KMime::Message::Ptr &

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D24035

To: gjditchfield, #kde_pim, mlaurent
Cc: mlaurent, knauss, kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190918/592db420/attachment.html>