akonadi-contacts 19.08 link failure windows

[Kevin Funk]

On Tuesday, 10 September 2019 00:28:23 CEST Allen Winter wrote:
> I'm getting this strange link error on Windows with 19.08 tarball (well, I
> *think* craft uses the official tarball releases)
> 
> I'm wondering if a backport of 2f552ac573770ce22ec5489b22c6269280aa4e36 from
> master would fix it.  And if so.. I think I'll need to wait until the next
> 19.0x release or beg for a respin.

Heya,

Note that this commit is already part of the 19.08.0 release:

% git tag --contains=2f552ac573770ce22ec5489b22c6269280aa4e36
v19.07.80
v19.07.90
v19.08.0
v19.08.1

So this can't be the culprit.

Just had a quick glance at the code and I don't see what could be the reason 
for getting this compile error, though.

Sorry,
Kevin

 
> (too bad this got past the CI)
> 
>  [1996/233] Linking CXX executable bin\phonewidgettest.exe
> FAILED: bin/phonewidgettest.exe
> cmd.exe /C "cd . &&
> C:\Craft\windows-msvc2017_64-cl\dev-utils\cmake\bin\cmake.exe -E
> vs_link_exe
> --intdir=src\contact-editor\editor\generalinfoeditor\autotests\CMakeFiles\p
> honewidgettest.dir --manifests  --
> C:\PROGRA~2\MIB055~1\2019\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\HostX64\x64
> \link.exe /nologo
> src\contact-editor\editor\generalinfoeditor\autotests\CMakeFiles\phonewidge
> ttest.dir\phonewidgettest.cpp.obj
> src\contact-editor\editor\generalinfoeditor\autotests\CMakeFiles\phonewidge
> ttest.dir\phonewidgettest_autogen\mocs_compilation.cpp.obj 
> /out:bin\phonewidgettest.exe /implib:lib\phonewidgettest.lib
> /pdb:bin\phonewidgettest.pdb /version:0.0  /machine:x64
> /NODEFAULTLIB:libcmt /DEFAULTLIB:msvcrt /debug /INCREMENTAL 
> /subsystem:windows  C:\Craft\windows-msvc2017_64-cl\lib\Qt5Test.lib
> lib\KF5ContactEditor.lib
> C:\Craft\windows-msvc2017_64-cl\lib\KF5Contacts.lib
> C:\Craft\windows-msvc2017_64-cl\lib\KF5Completion.lib
> C:\Craft\windows-msvc2017_64-cl\lib\KF5IconThemes.lib
> C:\Craft\windows-msvc2017_64-cl\lib\KF5I18n.lib
> C:\Craft\windows-msvc2017_64-cl\lib\Qt5Widgets.lib
> C:\Craft\windows-msvc2017_64-cl\lib\Qt5Gui.lib
> C:\Craft\windows-msvc2017_64-cl\lib\Qt5Core.lib
> C:\Craft\windows-msvc2017_64-cl\lib\qtmain.lib kernel32.lib user32.lib
> gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib
> comdlg32.lib advapi32.lib && cd ." LINK Pass 1: command
> "C:\PROGRA~2\MIB055~1\2019\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\HostX64\x6
> 4\link.exe /nologo
> src\contact-editor\editor\generalinfoeditor\autotests\CMakeFiles\phonewidge
> ttest.dir\phonewidgettest.cpp.obj
> src\contact-editor\editor\generalinfoeditor\autotests\CMakeFiles\phonewidge
> ttest.dir\phonewidgettest_autogen\mocs_compilation.cpp.obj
> /out:bin\phonewidgettest.exe /implib:lib\phonewidgettest.lib
> /pdb:bin\phonewidgettest.pdb /version:0.0 /machine:x64 /NODEFAULTLIB:libcmt
> /DEFAULTLIB:msvcrt /debug /INCREMENTAL /subsystem:windows
> C:\Craft\windows-msvc2017_64-cl\lib\Qt5Test.lib lib\KF5ContactEditor.lib
> C:\Craft\windows-msvc2017_64-cl\lib\KF5Contacts.lib
> C:\Craft\windows-msvc2017_64-cl\lib\KF5Completion.lib
> C:\Craft\windows-msvc2017_64-cl\lib\KF5IconThemes.lib
> C:\Craft\windows-msvc2017_64-cl\lib\KF5I18n.lib
> C:\Craft\windows-msvc2017_64-cl\lib\Qt5Widgets.lib
> C:\Craft\windows-msvc2017_64-cl\lib\Qt5Gui.lib
> C:\Craft\windows-msvc2017_64-cl\lib\Qt5Core.lib
> C:\Craft\windows-msvc2017_64-cl\lib\qtmain.lib kernel32.lib user32.lib
> gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib
> comdlg32.lib advapi32.lib /MANIFEST
> /MANIFESTFILE:src\contact-editor\editor\generalinfoeditor\autotests\CMakeFi
> les\phonewidgettest.dir/intermediate.manifest
> src\contact-editor\editor\generalinfoeditor\autotests\CMakeFiles\phonewidge
> ttest.dir/manifest.res" failed (exit code 1120) with the following output:
> phonewidgettest.cpp.obj : error LNK2001: unresolved external symbol
> "public: static struct QMetaObject const
> ContactEditor::PhoneComboBoxType::staticMetaObject"
> (?staticMetaObject at PhoneComboBoxType@ContactEditor@@2UQMetaObject@@B)
> bin\phonewidgettest.exe : fatal error LNK1120: 1 unresolved externals


-- 
Kevin Funk | kfunk at kde.org | http://kfunk.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190910/214b4986/attachment-0001.sig>