D23649: feat(mimetreeparser): Support MemoryHole in MimeTreeParser.

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Looks good, mostly small nitpicks.

INLINE COMMENTS

> messagepart.cpp:1042
> +{
> +        const auto extraContent = mOtp->nodeHelper()->decryptedNodeForContent(content());
> +        if (extraContent) {

Bad indentation

> messagepart.cpp:1393
> +{
> +        const auto extraContent = mOtp->nodeHelper()->decryptedNodeForContent(content());
> +        if (extraContent) {

Wrong indentation

> nodehelper.cpp:545
>  {
> -    return message->date()->dateTime();
> +    if (!mHeaderOverwrite.contains(message)) {
> +        mHeaderOverwrite[message] = QVector<MessagePart::Ptr>();

This if is not needed, the vector will be allocated automatically by `QMap::operator[]` if it does not exist yet.

> nodehelper.h:85
> +    void clearOverrideHeaders();
> +    void registerOverrideHeader(KMime::Content *message, MessagePartPtr);
> +    bool hasMailHeader(const char *header, const KMime::Content *message) const;

Should this be called "registerHeaderOverride", since the message part is an override for the "existing" headers (and similarly elsewhere) ?

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D23649

To: knauss, dvratil, aheinecke
Cc: kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190910/90e19987/attachment-0001.html>