D23820: [KSieve] Fix messagebox about connection to server lost

David Faure noreply at phabricator.kde.org
Tue Sep 10 09:51:25 BST 2019


dfaure created this revision.
dfaure added reviewers: ervin, knauss, mlaurent.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
dfaure requested review of this revision.

REVISION SUMMARY
  If the TCP idle timeout kicks in, or we time out trying to connect,
  and the user isn't manually doing something sieve related (no job),
  this isn't worth bothering the user about.
  
  This typically happens some time after starting kmail, for the initial
  vacation check.
  
  The 2019 Akademy university network was the ideal testcase for this
  (due to blocked ports) but I also regularly get this elsewhere.

TEST PLAN
  start kmail, wait. There is no longer two annoying messageboxes
  popping up (two because we have two sieve sessions at all times).
  
  The lack of the word Sieve in the messageboxes made this even more irritating
  (they were completely out of context) but that's for master (i18n change).

REPOSITORY
  R91 PIM: Sieve Handling Library

BRANCH
  Applications/19.08

REVISION DETAIL
  https://phabricator.kde.org/D23820

AFFECTED FILES
  src/kmanagesieve/session.cpp
  src/kmanagesieve/session.h
  src/kmanagesieve/sessionthread.cpp
  src/kmanagesieve/sessionthread_p.h

To: dfaure, ervin, knauss, mlaurent
Cc: kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190910/84df1e52/attachment.html>


More information about the kde-pim mailing list