D23908: feat(akonadiserver): Add AppArmor profile for akonadiserver

[Sandro Knauß]

knauss added inline comments.

INLINE COMMENTS

> dvratil wrote in CMakeLists.txt:143
> The default needs to be toggled to FALSE now to make it opt-in for packagers... :-)

As I already said, I think it should be opt-out, because it is a security feature, so every one who supports should enable it! And for those that don't support AppArmor, those file don't hurt, they are just annoying. With the default TRUE, we treat packagers to install Akonadi as secure as possible.

> dvratil wrote in CMakeLists.txt:143
> I would prefer this to be opt-in, rather than opt-out (and generally, options should be named positively (`INSTALL_APPARMOR`)

The reason to opt-out instead of opt-in is, that it enhance security, so everyone who is using AppArmor should use it and having these files lying around don't harm anyone. 
I call this "Security by Default".

But yes we can call it INSTALL_APPARMOR and make it as TRUE by default, that would do the same

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D23908

To: knauss, jriddell, dvratil
Cc: cgiboudeaux, kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20191007/bfa5008e/attachment.html>