D25213: Cancel task if conversion to XML fail

[Carl Schwan]

ognarb added a comment.


  In D25213#560009 <https://phabricator.kde.org/D25213#560009>, @mlaurent wrote:
  
  > Did you tested it ?
  >
  >   bool ContactGroupTool::convertToXml(const ContactGroup &group, QIODevice *device, QString *errorMessage)
  >    {
  >        Q_UNUSED(errorMessage);
  >   
  >        XmlContactGroupWriter writer;
  >        writer.write(group, device);
  >   
  >        return true;
  >    }
  >
  > errorMessage was never used. So you will report an empty string.
  >
  > What is the test case for this bug ?
  
  
  So if the method never fail we should probably add this quite useful information in the doc and add a TODO KF6 to change the method signature

REPOSITORY
  R44 KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D25213

To: ognarb, #kde_pim
Cc: mlaurent, kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20191108/bb7e8bd2/attachment.html>