D25213: Cancel task if conversion to XML fail

[Laurent Montel]

mlaurent added a comment.


  Did you tested it ?
  
    bool ContactGroupTool::convertToXml(const ContactGroup &group, QIODevice *device, QString *errorMessage)
    {
        Q_UNUSED(errorMessage);
    
        XmlContactGroupWriter writer;
        writer.write(group, device);
    
        return true;
    }
  
  errorMessage was never used. So you will report an empty string.
  
  What is the test case for this bug ?

REPOSITORY
  R44 KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D25213

To: ognarb, #kde_pim
Cc: mlaurent, kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20191108/e4ce7e94/attachment.html>