D24929: [pop3 kioslave] Port KTcpSocket (deprecated) to QSslSocket

Ahmad Samir noreply at phabricator.kde.org
Fri Nov 1 17:53:00 GMT 2019


ahmadsamir added a comment.


  In D24929#557643 <https://phabricator.kde.org/D24929#557643>, @vkrause wrote:
  
  > I think we cannot ifdef the two cases in this way, we need to assume that the 19.08.3 release is not rebuild by distros when updating to the 5.65 KF release.
  >  That is, if the KF version is higher than 5.65 we can drop the KTcpSocket case, but not the other way around. In that case we need to check which socket type we get at runtime (ie. cast to both types and check which one succeeds).
  
  
  Right, that makes sense, KIO_VERSION is checked at build time not run time. I'll update the diff.

REPOSITORY
  R44 KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D24929

To: ahmadsamir, mlaurent
Cc: vkrause, kde-pim, fbampaloukas, dvasin, rodsevich, winterz, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20191101/21449077/attachment-0001.html>


More information about the kde-pim mailing list