D21093: Fix memory leak due to getTestMonitor()

David Faure noreply at phabricator.kde.org
Thu May 9 10:31:50 BST 2019


dfaure created this revision.
dfaure added a reviewer: dvratil.
dfaure requested review of this revision.

REVISION SUMMARY
  asan build said the Monitor was leaked, and it was indeed.
  Fixed using std::unique_ptr.

TEST PLAN
  cmake -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DECM_ENABLE_SANITIZERS="address" -DCMAKE_CXX_FLAGS='-stdlib=libc++' -DCMAKE_SHARED_LINKER_FLAGS='-stdlib=libc++' -DCMAKE_EXE_LINKER_FLAGS='-stdlib=libc++' .. && make && ctest
  (with an asan build of Qt)

BRANCH
  Applications/19.04

REVISION DETAIL
  https://phabricator.kde.org/D21093

AFFECTED FILES
  autotests/libs/collectioncreatetest.cpp
  autotests/libs/itemdeletetest.cpp
  autotests/libs/itemmovetest.cpp
  autotests/libs/test_utils.h

To: dfaure, dvratil
Cc: kde-pim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190509/f563cecc/attachment.html>


More information about the kde-pim mailing list