D21154: Automatically run pg_upgrade when major PostgreSQL upgrade is detected

[Daniel Vrátil]

dvratil added inline comments.

INLINE COMMENTS

> knauss wrote in dbconfigpostgresql.cpp:215
> really "\\(" ? this is different in different languages, did you tested your regex?

The regular expression is "\(", you have to escape the backslash in the C string.

> knauss wrote in dbconfigpostgresql.cpp:254
> I understand the difference, but in` init() ` you ONLY check `/usr/lib/postgresql/*/bin` and not 
> `/usr/lib64/pgsql/postgresql-*/bin`  and `/usr/lib/pgsql/postgresql-*/bin`. I would argue that those dictionaries should be searched in `init()` too. Because also for other Distributions the new postgres version won't be available in normal search path.Otherwise we will end up in situations, where we fix one place and add a new Distribution style and forget in the other function et visa versa.

The difference is that on Fedora for instance, the latest version is in `/usr/bin`, `/usr/lib64/pgsql/postgresql-*` contains the older versions - in `init()` we only want the latest version, while here we actively look for an older version.

I will refactor this together with the update to versioned lookup in a next patch.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D21154

To: dvratil, #kde_pim
Cc: knauss, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190519/09f0c023/attachment.html>