D21464: IMAP: Option to use system proxy settings (Configuration and GUI)
Jonathan Marten
noreply at phabricator.kde.org
Tue May 28 16:43:11 BST 2019
marten created this revision.
marten added a reviewer: KDE PIM.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
marten requested review of this revision.
REVISION SUMMARY
This is to provide an explicit option to not use the system proxy setting for IMAP connections, as described in T7430 <https://phabricator.kde.org/T7430>. This was originally intended to be implemented for IMAP as well as SMTP and POIP3, but it got overlooked. https://bugs.kde.org/show_bug.cgi?id=407685 refers.
D21643 implements the proxy option in the IMAP core library. This is the GUI for the setting, which appears as an additional option in the "Advanced" tab of the account settings dialogue.
F6856767: pimproxy-imap-after.png <https://phabricator.kde.org/F6856767>
TEST PLAN
Built pimruntime with this change. Verified that the account option is correctly saved in the agent configuration file and that it controls whether the IMAP resource connects via the proxy.
REPOSITORY
R44 KDE PIM Runtime
REVISION DETAIL
https://phabricator.kde.org/D21464
AFFECTED FILES
resources/imap/imapaccount.cpp
resources/imap/imapaccount.h
resources/imap/imapresource.kcfg
resources/imap/sessionpool.cpp
resources/imap/settings.cpp
resources/imap/setupserver.cpp
resources/imap/setupserverview_desktop.ui
To: marten, #kde_pim
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190528/07cdbb56/attachment.html>
More information about the kde-pim
mailing list