D21066: Statusbar progress widget code cleanup: pass Mode to setMode

Daniel Vrátil noreply at phabricator.kde.org
Tue May 7 18:05:17 BST 2019


dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> statusbarprogresswidget.cpp:245
>  {
> +    mMode = mode;
>      switch (mMode) {

`return` when `mMode == mode`? Or does the code rely on the side-effects?

REVISION DETAIL
  https://phabricator.kde.org/D21066

To: dfaure, mlaurent, dvratil
Cc: dvratil, kde-pim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190507/e9c7207e/attachment.html>


More information about the kde-pim mailing list