D20945: KContacts - fix compile warnings

Daniel Vrátil noreply at phabricator.kde.org
Thu May 2 16:17:19 BST 2019


dvratil added inline comments.

INLINE COMMENTS

> ldifconverter.cpp:122
>      for (it = contactGroupList.constBegin(); it != end; ++it) {
> -        contactGroupToLDIF(*it, str);
> +        result = (contactGroupToLDIF(*it, str) || result); //order matters
>      }

You could simplify by using `result |= contactGroupToLDIF(*it, str)`

REPOSITORY
  R174 PIM: KContacts

REVISION DETAIL
  https://phabricator.kde.org/D20945

To: winterz, vkrause, mlaurent
Cc: dvratil, pino, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190502/1f252c5a/attachment.html>


More information about the kde-pim mailing list