D21215: Create second-type duration for 0 delay durations in ical format.

[Damien Caliste]

dcaliste created this revision.
dcaliste added a reviewer: vkrause.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
dcaliste requested review of this revision.

REVISION SUMMARY
  In various portion of the code, Duration( 0 ) is used to represent a zero delay duration (see alarm.cpp for examples). This is creating a Duration::Seconds type duration. But when reading an ical format, the zero delay duration is created with Duration( 0, Days ) which makes comparison always fail for zero delay durations…
  
  This is part of two patches that have been added to the SailfishOS fork of KCalCore.

TEST PLAN
  The added testAlarm() function added by the patch in testicalformat.cpp is failing without the patch. This test is basically creating an alarm which triggers on time and export it to iCal format. Then the serialized data are parsed again and compared with initial alarm.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D21215

AFFECTED FILES
  autotests/testicalformat.cpp
  autotests/testicalformat.h
  src/icalformat_p.cpp

To: dcaliste, vkrause
Cc: kde-pim, pvuorela, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190514/a7b7a7d4/attachment.html>