D20993: Adapt to API changes

Daniel Vrátil noreply at phabricator.kde.org
Sat May 4 08:31:17 BST 2019


dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> contactprintthemepreview.h:51
>      KContacts::Addressee mContact;
> -    KAddressBookGrantlee::GrantleePrint *mGrantleePrint = nullptr;
> +    std::unique_ptr<KAddressBookGrantlee::GrantleePrint> mGrantleePrint;
>      QWebEngineView *mViewer = nullptr;

Could be on stack, as well?

REPOSITORY
  R203 Grantlee Editor

REVISION DETAIL
  https://phabricator.kde.org/D20993

To: vkrause, dvratil
Cc: dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190504/174273b9/attachment.html>


More information about the kde-pim mailing list