D21236: Fix crashes with Qt 5.12

Wolfgang Bauer noreply at phabricator.kde.org
Wed May 15 20:31:51 BST 2019


wbauer created this revision.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
wbauer requested review of this revision.

REVISION SUMMARY
  Commit 1ccd6815 <https://phabricator.kde.org/R201:1ccd68157a1309a2b11f3cece420bb2df6da2e02> moved the creation of the `mNetworkAccessManager` down without a mentioned reason,
  but that apparently causes crashes with Qt 5.12 at least.
  
  Moving it back to the top seems to fix that.

TEST PLAN
  Open and close tabs a couple of times.
  
  Akregator would soon crash here (with Qt 5.12.3), at the second or third time at the latest.
  With this patch, no crashes anymore.
  
  Haven't tested it with Qt 5.13 though.

REPOSITORY
  R201 Akregator

REVISION DETAIL
  https://phabricator.kde.org/D21236

AFFECTED FILES
  src/articleviewer-ng/webengine/articleviewerwebengine.cpp

To: wbauer
Cc: mlaurent, kde-pim, amantia, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190515/f8d2a34d/attachment.html>


More information about the kde-pim mailing list