D21018: Clean up type selection combobox class hierarchy
Volker Krause
noreply at phabricator.kde.org
Sat May 4 18:23:20 BST 2019
vkrause created this revision.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
vkrause requested review of this revision.
REVISION SUMMARY
Having the URL one inherit the email one makes no sense, so decouple them,
remove the virtual method now no longer needed, and move the email one to
its sub-directory.
Prepares this for porting the email editor to the new KContacts API rather
than using string-based access.
REPOSITORY
R459 Akonadi Contacts
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21018
AFFECTED FILES
src/contact-editor/CMakeLists.txt
src/contact-editor/editor/generalinfoeditor/autotests/contactselecttypecomboboxtest.cpp
src/contact-editor/editor/generalinfoeditor/contactselecttypecombobox.cpp
src/contact-editor/editor/generalinfoeditor/contactselecttypecombobox.h
src/contact-editor/editor/generalinfoeditor/mail/mailtypecombobox.cpp
src/contact-editor/editor/generalinfoeditor/mail/mailtypecombobox.h
src/contact-editor/editor/generalinfoeditor/mail/mailwidget.cpp
src/contact-editor/editor/generalinfoeditor/mail/mailwidget.h
src/contact-editor/editor/generalinfoeditor/web/webselecttypecombobox.cpp
src/contact-editor/editor/generalinfoeditor/web/webselecttypecombobox.h
src/contact-editor/editor/generalinfoeditor/web/webwidget.cpp
To: vkrause
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190504/ad17efb1/attachment.html>
More information about the kde-pim
mailing list