D21463: KIMAP: Option to use system proxy settings (Core part)

[Jonathan Marten]

marten created this revision.
marten added a reviewer: KDE PIM.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
marten requested review of this revision.

REVISION SUMMARY
  This is to provide an explicit option to not use the system proxy setting for IMAP connections, as described in T7430 <https://phabricator.kde.org/T7430>.
  
  If the system proxy settings are set to use the environment variables http_proxy etc (for compatibility with non-KDE applications), then they are also used for IMAP connections. This is rarely required and will fail unless the proxy is transparent enough. See https://bugs.kde.org/show_bug.cgi?id=407685 and related bugs.
  
  This change adds a IMAP account option to use the proxy for connection (the default is off). This is the core part of the change; the visible GUI part will follow in another diff.

TEST PLAN
  Built kimap with this change, verified that by default the IMAP connection is not made via the proxy and that mail fetching works as expected. Verified that, if the option is set, the IMAP connection is made via the proxy.

REPOSITORY
  R177 PIM: KIMAP

REVISION DETAIL
  https://phabricator.kde.org/D21463

AFFECTED FILES
  src/session.cpp
  src/session.h
  src/sessionthread.cpp
  src/sessionthread_p.h

To: marten, #kde_pim
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190528/4531984e/attachment.html>