D21121: Fix leaking of requests in ItemRetriever::exec()

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> itemretriever.cpp:272
>              if (!lastRequest || lastRequest->ids.size() > 100) {
>                  lastRequest = new ItemRetrievalRequest();
>                  lastRequest->ids.push_back(pimItemId);

I don't agree because the "new" happens here.

> itemretriever.cpp:353
>              it = requests.erase(it);
>              delete request;
>              continue;

... and some requests get deleted here.

REVISION DETAIL
  https://phabricator.kde.org/D21121

To: dfaure, dvratil
Cc: anthonyfieroni, kde-pim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190510/08d811ea/attachment.html>