D19576: Add Team Drive create job feature.

Daniel Vrátil noreply at phabricator.kde.org
Fri Mar 8 10:02:20 GMT 2019


dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  One minor nitpick, otherwise looking good :) Thanks!

INLINE COMMENTS

> teamdrivecreatejob.h:40
> +  public:
> +    TeamdriveCreateJob(const QString &requestId,
> +                            const TeamdrivePtr &teamdrive,

Could you make the request ID accessible through a getter, so it's possible to pair the job to a request in `finished(Job*)` slot?

REPOSITORY
  R477 KGAPI Library

REVISION DETAIL
  https://phabricator.kde.org/D19576

To: barchiesi, dvratil
Cc: kde-pim, #libkgapi, barchiesi, gennad, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190308/b99a1930/attachment.html>


More information about the kde-pim mailing list