Possible issue with the dependency freeze for 19.04

[Daniel Vrátil]

On Friday, March 29, 2019 12:34:14 PM CET laurent Montel wrote:
> Le vendredi 29 mars 2019, 12:20:45 CET Daniel Vrátil a écrit :
> > On Friday, March 29, 2019 11:42:03 AM CET laurent Montel wrote:
> > > Le vendredi 29 mars 2019, 10:43:57 CET Daniel Vrátil a écrit :
> > > > On Thursday, March 28, 2019 6:51:49 PM CET Heiko Becker wrote:
> > > > > Hi,
> > > > > 
> > > > > I wondered why korganizer and mailcommon suddenly moved from phonon
> > > > > to
> > > > > qtmultimedia and I tried to get some information about it (Turns out
> > > > > the
> > > > > commit messages don't help one bit, e.g. "Clean up"). Anyway, this
> > > > > happened
> > > > > on 21 March, a week after dependency freeze and it was suggested to
> > > > > me
> > > > > to
> > > > > bring this to the attention of this mailing list.
> > > > 
> > > > I think we should revert this - QtMultimedia is not integrated with
> > > > KDE
> > > > the
> > > > way Phonon is - we should use Phonon in KDE apps to provide consistent
> > > > experience.
> > > > 
> > > > Laurent, what was the motivation for the switch?
> > > 
> > > Just for reducing extra lib.
> > > Just for playing a song (when a message arrives) I don't see why we need
> > > to
> > > add this dependency.
> > 
> > You literally only replaced one dependency by another. Absolutely nothing
> > was gained here....the entire PIM already depends on Phonon,
> 
> Just the 2 area which I ported.
> Not other phonon references.
> 
> > everything in
> > KDE depends on Phonon, all you achieved by this is, that the app no longer
> > follows user's KDE-wide audio settings.
> 
> Ok so you can revert it.

Also in the future, please be more descriptive in the commit messages, "Clean 
up" is so generic it could mean anything. Why not say "Switch from Phonon to 
QtMultimedia"? 

Thanks,
Dan

> 
> > > > Dan
> > > > 
> > > > > Cheers,
> > > > > Heiko
> > > > > 
> > > > > [1]
> > > > > https://community.kde.org/Schedules/Applications/19.04_Release_Sched
> > > > > ul
> > > > > e


-- 
Daniel Vrátil
www.dvratil.cz | dvratil at kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)

GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190329/7c83c306/attachment.sig>