D19488: TransactionSequence: cancel all subjobs on rollback-from-user.

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> dvratil wrote in transactionsequence.cpp:249
> So why not kill the subjobs quietly? Since we are cancelling them, we don't care about their result, right?

That's one of the things I tried, and it means mPendingJobs isn't decremented in ItemSync so the itemsync never finishes.

(of course Quietly also requires calling KCompositeJob::removeSubjob(job) here in the loop, to avoid keeping dangling jobs in subjobs(), but that's the easy part)

BRANCH
  transaction_stuff

REVISION DETAIL
  https://phabricator.kde.org/D19488

To: dfaure, dvratil, vkrause
Cc: kde-pim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190313/5c6e03e1/attachment.html>