D20040: Don't finish collection sync task too early

[Daniel Vrátil]

dvratil added inline comments.

INLINE COMMENTS

> mwolff wrote in resourcebase.cpp:136
> see the last comment here: https://bugs.kde.org/show_bug.cgi?id=403642
> 
> `agentbase.cpp`'s `collectionChanged` calls `changeProcessed` and then afterwards we get the `Akonadi::ResourceBasePrivate::changeCommittedResult` signal handler calling `changeProcessed` again. I naively (i.e. without digging deep) thought that this comes from the same change replay, and it should only call `taskDone` once, instead of twice like it is doing currently.
> 
> Is that enough info for you, or do you need more? How would you "find out what resource implementation" it is? This is always the imap resource which asserts. I can `rr record` this and send it to you, if you are interested?

I think I found a root cause for the issue, I attached a patch to your bug report, please test it and let me know.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D20040

To: mwolff, dvratil, dfaure
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190325/43ee2ce1/attachment.html>