D19490: Refactor FileSearchQuery and create base class SearchQuery

David Barchiesi noreply at phabricator.kde.org
Sun Mar 3 11:17:59 GMT 2019


barchiesi created this revision.
barchiesi added a reviewer: dvratil.
barchiesi added a project: LibKGAPI.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
barchiesi requested review of this revision.

REVISION SUMMARY
  As discussed in  T10521 <https://phabricator.kde.org/T10521#177460>, it is useful to refactor out the generic query building logic in FileSearchQuery and create the base class SearchQuery. This would allow us to create other domain specific queries without having to reimplement all the building logic, as will be the case with TeamdriveSearchQuery.

TEST PLAN
  All tests defined in filesearchquerytest should remain valid as as of this patch passing.

REPOSITORY
  R477 KGAPI Library

REVISION DETAIL
  https://phabricator.kde.org/D19490

AFFECTED FILES
  src/drive/CMakeLists.txt
  src/drive/filesearchquery.cpp
  src/drive/filesearchquery.h
  src/drive/searchquery.cpp
  src/drive/searchquery.h

To: barchiesi, dvratil
Cc: kde-pim, #libkgapi, barchiesi, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190303/76eb85d7/attachment.html>


More information about the kde-pim mailing list